feat(react-toolbar): expose base hooks and types for Toolbar components#35903
Open
dmytrokirpa wants to merge 2 commits intomicrosoft:masterfrom
Open
feat(react-toolbar): expose base hooks and types for Toolbar components#35903dmytrokirpa wants to merge 2 commits intomicrosoft:masterfrom
dmytrokirpa wants to merge 2 commits intomicrosoft:masterfrom
Conversation
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 404 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 12 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 172 | Changed |
vr-tests-react-components/ProgressBar converged 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png | 27 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png | 25 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 68 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
dmytrokirpa
force-pushed
the
feat/react-toolbar-expose-base-hooks
branch
from
fc76df2 to
80ea1e9
Compare
1 task
dmytrokirpa
force-pushed
the
feat/react-toolbar-expose-base-hooks
branch
from
aff6b2a to
51bf3d3
Compare
layershifter
requested changes
Apr 20, 2026
Member
layershifter
left a comment
layershifter
left a comment
There was a problem hiding this comment.
Default vs user props overrides
It's a bit tricky to review these changes as a small change in order could break things. As we have already faced regressions before (#35710), please cover matching changes with UTs (use linked PR for reference)
Thx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useToolbarBase_unstable,ToolbarBaseProps,ToolbarBaseStateuseToolbarButtonBase_unstable,ToolbarButtonBaseProps,ToolbarButtonBaseStateuseToolbarDividerBase_unstable,ToolbarDividerBaseProps,ToolbarDividerBaseStateuseToolbarRadioButtonBase_unstable,ToolbarRadioButtonBaseProps,ToolbarRadioButtonBaseStateuseToolbarToggleButtonBase_unstable,ToolbarToggleButtonBaseProps,ToolbarToggleButtonBaseStaterenderToolbar_unstableto acceptToolbarBaseStateinstead ofToolbarState— the render only usesstate.root.childrenwhich is present in the base stateAll hooks and types were already implemented in the component source files (added in PR #35658) but gated behind comments in
index.ts.Tracking: #35562
🤖 Generated with Claude Code